[PATCH] D66246: [AMDGPU] Do not assume a default GCN target

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 13:15:33 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Basic/Targets/AMDGPU.cpp:188-189
       break;
     case GK_NONE:
-      return false;
+      break;
     default:
----------------
I think this needs to distinguish no specified target from an invalid cpu name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66246/new/

https://reviews.llvm.org/D66246





More information about the llvm-commits mailing list