[PATCH] D65529: [PowerPC] Use xxleqv to set all one vector IMM(-1).

[Zixuan Wu (Zeson) via Phabricator via llvm-commits]

wuzish added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:390
+def immAnyExt8NonAllOne : ImmLeaf<i32, [{ return (isInt<8>(Imm) && (Imm != -1))
+                                              || (isUInt<8>(Imm) && (Imm != 0xFF)); }]>;
 def immSExt5NonZero : ImmLeaf<i32, [{ return Imm && isInt<5>(Imm); }]>;
----------------
steven.zhang wrote:
> line too long. immAnyExt8NonAllOnes or immNonAllOnesAnyExt8?
I think no need to modify this to exclude all ones. So long as its position which is blow all ones Pat, it would not be selected before all ones. Can have a try.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65529/new/

https://reviews.llvm.org/D65529