[PATCH] D65529: [PowerPC] Use xxleqv to set all one vector IMM(-1).

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang accepted this revision.
steven.zhang added a comment.
This revision is now accepted and ready to land.

LGTM except some minor comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:390
+def immAnyExt8NonAllOne : ImmLeaf<i32, [{ return (isInt<8>(Imm) && (Imm != -1))
+                                              || (isUInt<8>(Imm) && (Imm != 0xFF)); }]>;
 def immSExt5NonZero : ImmLeaf<i32, [{ return Imm && isInt<5>(Imm); }]>;
----------------
line too long. immAnyExt8NonAllOnes or immNonAllOnesAnyExt8?


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:1328
+            (v8i16 (COPY_TO_REGCLASS(XXLEQVOnes), VSRC))>;
+  def : Pat<(v16i8 (bitconvert (v16i8 immAllOnesV))),
+            (v16i8 (COPY_TO_REGCLASS(XXLEQVOnes), VSRC))>;
----------------
Can we put these pattern in line 4112 to match the build vector in the same place ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65529/new/

https://reviews.llvm.org/D65529