[PATCH] D64384: [WIP] Index-while-building

[Jan Korous via Phabricator via llvm-commits]

jkorous marked 10 inline comments as done.
jkorous added a comment.

Thanks for the review! I addressed just some minor details so far.



================
Comment at: clang/include/clang/Frontend/CompilerInstance.h:810
+    return GenModuleActionWrapper;
+  }
+
----------------
gribozavr wrote:
> I don't see anything actually using `GenModuleActionWrapper`.
IIUC it's both used (lambda on CompilerInstance.cpp:L1136) and passed (CompilerInstance.cpp:L1112) to `CompilerInstance` of module dependencies in `compileModuleImpl`.


================
Comment at: clang/unittests/Index/IndexTests.cpp:106
 
+  virtual void setPreprocessor(std::shared_ptr<Preprocessor> PP) override {}
+  virtual bool handleModuleOccurence(const ImportDecl *ImportD,
----------------
gribozavr wrote:
> Unclear why this test overrides these methods, if the implementation is identical to the base class.
Removed these overrides.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64384/new/

https://reviews.llvm.org/D64384