[PATCH] D64384: [WIP] Index-while-building

Jan Korous via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 18:55:05 PDT 2019


jkorous marked 2 inline comments as done.
jkorous added inline comments.


================
Comment at: clang/include/clang/Index/IndexAction.h:22
+
+/// This is primarily a hack - poking hole through FrontendAction encapsulation
+/// in order to access protected methods from IndexActionWrapper. FIXME?
----------------
gribozavr wrote:
> +1. Instead of `WrapperFrontendAction`, could you implement a general frontend action multiplexer in `clang/include/clang/Frontend/FrontendAction.h` ? You can do that as a separate commit.
Sent for review: https://reviews.llvm.org/D66125
I'll rebase this patch once/if that lands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64384/new/

https://reviews.llvm.org/D64384





More information about the llvm-commits mailing list