[PATCH] D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 13 10:42:51 PDT 2019
daltenty marked 2 inline comments as done.
daltenty added inline comments.
================
Comment at: llvm/lib/MC/MCSymbolXCOFF.cpp:14
+
+const MCSectionXCOFF *MCSymbolXCOFF::getContainingCSect() const {
+ assert(ContainingCSect && "Trying to get containing csect but none was set.");
----------------
jasonliu wrote:
> Is it necessary to put these two functions in the .cpp file?
> These two functions doesn't look complicated, and should be Okay to exist in the header.
I will move these to the header in the commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66032/new/
https://reviews.llvm.org/D66032
More information about the llvm-commits
mailing list