[PATCH] D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1688
+void PPCAIXAsmPrinter::EmitStartOfAsmFile(Module &M) {
+  // Map the TOC anchor to it's containing Csect, since we will almost always
+  // need it. That way other methods can query it freely assuming it is set.
----------------
sfertile wrote:
> minor nit: 'Csect' --> 'csect'
Minor nits:
  - s/it's/its/;
  - Move "it" closer to its referent (the TOC anchor) by swapping the order of the first sentence: Since [ ... ], map [ ... ].




================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1689
+  // Map the TOC anchor to it's containing Csect, since we will almost always
+  // need it. That way other methods can query it freely assuming it is set.
+  StringRef TOC("TOC");
----------------
That way, other methods can freely query it, assuming that it is set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66032/new/

https://reviews.llvm.org/D66032