[PATCH] D66011: [llvm-readobj] - Remove 'error(Error EC)' helper.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 04:07:00 PDT 2019


grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1170
 
   if (auto EC = CVSD.dump(Symbols)) {
     W.flush();
----------------
grimar wrote:
> jhenderson wrote:
> > Is EC an Error or std::error_code? If the latter, the move below is unnecessary.
> It's an `Error`. `EC` is a bad original name, I can change it to `E` before the commit.
Will also replace `auto` with an explicit type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66011/new/

https://reviews.llvm.org/D66011





More information about the llvm-commits mailing list