[PATCH] D66011: [llvm-readobj] - Remove 'error(Error EC)' helper.

[George Rimar via Phabricator via llvm-commits]

grimar marked 3 inline comments as done.
grimar added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1170
 
   if (auto EC = CVSD.dump(Symbols)) {
     W.flush();
----------------
jhenderson wrote:
> Is EC an Error or std::error_code? If the latter, the move below is unnecessary.
It's an `Error`. `EC` is a bad original name, I can change it to `E` before the commit.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1271
                                       Types, Hashes, PCHSignature))
-          return error(std::move(EC));
+          return reportError(std::move(EC), Obj->getFileName());
       } else {
----------------
jhenderson wrote:
> Same comment here and immediately below as above.
It is also an `Error` returned here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66011/new/

https://reviews.llvm.org/D66011