[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

Mon Aug 12 11:06:48 PDT 2019

lebedev.ri added a comment.

In D65148#1625432 <https://reviews.llvm.org/D65148#1625432>, @craig.topper wrote:

> In D65148#1624962 <https://reviews.llvm.org/D65148#1624962>, @lebedev.ri wrote:
>
> > In D65148#1624762 <https://reviews.llvm.org/D65148#1624762>, @craig.topper wrote:
> >
> > > Did anything happen with the extractvalue cost suggestion?
> >
> >
> > I was planning to look into that, and i just did. Some observations:
> >
> > 1. I'm not sure we can literally treat any `extractvalue` as free, it clearly isn't: https://godbolt.org/z/6wIxAa
>
>
> For the short cases, the mov belongs to the return not the extractvalue. For the large cases all of that code is the result of passing an array by value.

Okay, D66098 <https://reviews.llvm.org/D66098>.
If accepted, i will rebase this patch ontop of that committed patch,
and split this particular patch out of patchset - i'm still rather interested
in this change, and i'm not seeing any alternative solutions for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148