[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D65148#1624962 <https://reviews.llvm.org/D65148#1624962>, @lebedev.ri wrote:

> In D65148#1624762 <https://reviews.llvm.org/D65148#1624762>, @craig.topper wrote:
>
> > Did anything happen with the extractvalue cost suggestion?
>
>
> I was planning to look into that, and i just did. Some observations:
>
> 1. I'm not sure we can literally treat any `extractvalue` as free, it clearly isn't: https://godbolt.org/z/6wIxAa


For the short cases, the mov belongs to the return not the extractvalue. For the large cases all of that code is the result of passing an array by value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148