[PATCH] D66023: Warning disable for mod-by-zero and union 'uninitialized' use

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 13:37:43 PDT 2019


mstorsjo added inline comments.


================
Comment at: compiler-rt/lib/builtins/fixunsxfdi.c:48
+#pragma warning(pop)
 #endif
----------------
This broke compilation for me with errors like this:

```
lib/builtins/fixunsxfdi.c:13:2: error: unterminated conditional directive
#if !_ARCH_PPC
```

Also, the commit message speaks about sanitizers, even though all the changes are for builtins.

I fixed the compile error in SVN r368480.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66023/new/

https://reviews.llvm.org/D66023





More information about the llvm-commits mailing list