[PATCH] D66023: Warning disable for mod-by-zero and union 'uninitialized' use

[Matthew G McGovern via Phabricator via llvm-commits]

mcgov closed this revision.
mcgov added inline comments.


================
Comment at: compiler-rt/lib/builtins/udivmoddi4.c:21-22
+#ifdef _MSC_VER
+// MSVC throws a warning about mod 0 here, disable it for builds that
+// warn-as-error
+#pragma warning(push)
----------------
rnk wrote:
> I think the % by 0 will happen only in the cases where the user actually does division by zero, and that's actually the desired behavior.
Ok that makes sense. I appreciate the look, thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66023/new/

https://reviews.llvm.org/D66023