[PATCH] D65840: [X86] Support -march=tigerlake

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm marked 2 inline comments as done.
xiangzhangllvm added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:167
   case CK_IcelakeServer:
-    setFeatureEnabledImpl(Features, "pconfig", true);
-    setFeatureEnabledImpl(Features, "wbnoinvd", true);
+    if (Kind != CK_Tigerlake) {
+      setFeatureEnabledImpl(Features, "pconfig", true);
----------------
RKSimon wrote:
> Are we ok with introducing this kind of thing again or should we use goto?
Sorry, not quite understand, How to  introducing it again?


================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1569
+// CHECK_TGL_M32: #define __VPCLMULQDQ__ 1
+// CHECK_TGL_M32-NOT: #define __WBNOINVD__ 1
+// CHECK_TGL_M32: #define __XSAVEC__ 1
----------------
RKSimon wrote:
> You test for no-wbnoinvd - do we need to do the same for pconfig?
I am not much sure about the -wbnoinvd, The tigerlake  succeed to icelake, So I write the check follow the icelake.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65840/new/

https://reviews.llvm.org/D65840