[PATCH] D65840: [X86] Support -march=tigerlake

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:167
   case CK_IcelakeServer:
-    setFeatureEnabledImpl(Features, "pconfig", true);
-    setFeatureEnabledImpl(Features, "wbnoinvd", true);
+    if (Kind != CK_Tigerlake) {
+      setFeatureEnabledImpl(Features, "pconfig", true);
----------------
Are we ok with introducing this kind of thing again or should we use goto?


================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1569
+// CHECK_TGL_M32: #define __VPCLMULQDQ__ 1
+// CHECK_TGL_M32-NOT: #define __WBNOINVD__ 1
+// CHECK_TGL_M32: #define __XSAVEC__ 1
----------------
You test for no-wbnoinvd - do we need to do the same for pconfig?


================
Comment at: llvm/lib/Support/Host.cpp:749
     default: // Unknown family 6 CPU, try to guess.
+      // TODO detect tigerlake host
+
----------------
Check for tigerlake with avx512vp2intersect cpuid bit? @craig.topper any suggestions?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65840/new/

https://reviews.llvm.org/D65840