[PATCH] D65844: [MCA] Fix MSVC 19.16 build with libc++

[Orivej Desh via Phabricator via llvm-commits]

orivej updated this revision to Diff 214282.
orivej retitled this revision from "[MCA] Fix MSVC build with libc++" to "[MCA] Fix MSVC 19.16 build with libc++".
orivej added a comment.

Add a comment that this affects only MSVC >= 19.15, < 19.20.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65844/new/

https://reviews.llvm.org/D65844

Files:
  include/llvm/MCA/SourceMgr.h


Index: include/llvm/MCA/SourceMgr.h
===================================================================
--- include/llvm/MCA/SourceMgr.h
+++ include/llvm/MCA/SourceMgr.h
@@ -16,12 +16,13 @@
 #define LLVM_MCA_SOURCEMGR_H
 
 #include "llvm/ADT/ArrayRef.h"
+#include "llvm/MCA/Instruction.h"
 
 namespace llvm {
 namespace mca {
 
-class Instruction;
-
+// MSVC >= 19.15, < 19.20 need to see the definition of class Instruction to
+// prevent compiler error C2139 about intrinsic type trait '__is_assignable'.
 typedef std::pair<unsigned, const Instruction &> SourceRef;
 
 class SourceMgr {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65844.214282.patch
Type: text/x-patch
Size: 589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190809/8e9d2e70/attachment-0001.bin>