[PATCH] D65844: [MCA] Fix MSVC build with libc++

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a subscriber: gbedwell.
andreadb added a comment.
This revision is now accepted and ready to land.

A colleague ( @gbedwell ) pointed out that this is likely to be the same MSVC bug originally reported here:
https://developercommunity.visualstudio.com/content/problem/343550/webkit-an-undefined-class-is-not-allowed-as-an-arg.html.

That issue has been fixed by a more recent version of MSVC (presumably 19.20)
https://godbolt.org/resetlayout/vka9Vf

If that's the case, then your change is a good workaround. Maybe add a comment to the new include mentioning the problematic MSVC version, so that we can re-evaluate it in future.

Thanks!
-Andrea


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65844/new/

https://reviews.llvm.org/D65844