[PATCH] D65953: [llvm-readelf]Print filename for multiple inputs and fix formatting regression

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 18:15:40 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/llvm-readobj/file-name.test:28
+## The very first line should be blank. CHECK-EMPTY isn't allowed on the first line.
+# NAME1:      {{^}}
+# NAME1-NOT:  {{.}}
----------------
To test the first line is blank: `# NAME1: {{^$}}`

This is what readelf does (since its initial import in 1999):
```
  /* Process the file.  */
  if (show_name)
    printf (_("\nFile: %s\n"), filedata->file_name);
```

I think the blank line is pretty arbitrary. It is there just because it was easy to implement...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65953/new/

https://reviews.llvm.org/D65953





More information about the llvm-commits mailing list