[PATCH] D65953: [llvm-readelf]Print filename for multiple inputs and fix formatting regression

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 07:55:41 PDT 2019


jhenderson created this revision.
jhenderson added reviewers: grimar, MaskRay, rupprecht, wolfgangp, ychen.
Herald added a project: LLVM.

This patch addresses two closely related bugs: https://bugs.llvm.org/show_bug.cgi?id=42930 and https://bugs.llvm.org/show_bug.cgi?id=42931. GNU readelf prints the file name for every input unless there is only one input and that input is not an archive. This patch adds the printing for multiple inputs. A previous change did it for archives, but introduced a regression with GNU compatibility for single-output formatting, resulting in a spurious initial blank line. This is fixed in this patch too.


Repository:
  rL LLVM

https://reviews.llvm.org/D65953

Files:
  test/tools/llvm-readobj/elf-dynamic-malformed.test
  test/tools/llvm-readobj/file-name.test
  test/tools/llvm-readobj/stack-sizes.test
  tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65953.214154.patch
Type: text/x-patch
Size: 4534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190808/e5158e1c/attachment.bin>


More information about the llvm-commits mailing list