[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D65121#1621579 <https://reviews.llvm.org/D65121#1621579>, @probinson wrote:

> More bikeshedding:  The new substitution could be called `%TestFileCheckOutput` (thus not abbreviating Output to Out) which helps it to be more self-documenting.


That works for me, and I'll go with that if there's no further discussion.

> Or, it could be called `%TestFileCheckEnv` because its function is to set the environment, and it can optionally take an environment-variable definition as an argument. (Sorry if I already suggested this and we decided against.)

I like seeing `Env` there.  I don't like dropping `Output` because I want the reminder that FileCheck output is the reason to use this substitution.

I want to say `%SetEnvForTestingFileCheckOutput`, but that's too much.  Can we cram all that into something shorter?

Another possibility: `%ProtectFileCheckOutput`

> Everything else about this looks fine, LGTM once the substitution's name is settled.

We have time.  I want to see how things go with my related lit test suite work first, and there was a suggestion about documentation here that I haven't worked on.

Thanks again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121