[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 11:50:30 PDT 2019


probinson added a comment.

More bikeshedding:  The new substitution could be called `%TestFileCheckOutput` (thus not abbreviating Output to Out) which helps it to be more self-documenting.
Or, it could be called `%TestFileCheckEnv` because its function is to set the environment, and it can optionally take an environment-variable definition as an argument. (Sorry if I already suggested this and we decided against.)
Everything else about this looks fine, LGTM once the substitution's name is settled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121





More information about the llvm-commits mailing list