[PATCH] D63672: Added Delta IR Reduction Tool

[Diego Treviño via Phabricator via llvm-commits]

diegotf marked 4 inline comments as done.
diegotf added inline comments.


================
Comment at: llvm/test/BP2/remove-funcs-test.sh:1
+#!/bin/bash
+
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > 1. You can't assume there is bash, therefore you can't use it for tests
> > 2. there is `not` tool already
> I'll be more specific - you can not use shell at all, regardless of whether it's bash/sh/zsh/...
> It should be python-based.
Thanks for the clarification! I think it might be worthwhile writing that down somewhere (for future reference)


================
Comment at: llvm/test/Reduce/remove-funcs.ll:4
+;
+; RUN: llvm-reduce --test %p/Inputs/remove-funcs.py %s
+; RUN: cat reduced.ll | FileCheck %s
----------------
lebedev.ri wrote:
> I think i'm failing to see the purpose of that script.
> Why is it needed? FileCheck will fail just as good if it doesn't match.
It is used internally by the tool in order to reduce IR. And to clarify that I moved the script into an `Inputs` folder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672