[PATCH] D63672: Added Delta IR Reduction Tool

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/test/BP2/remove-funcs-test.sh:1
+#!/bin/bash
+
----------------
lebedev.ri wrote:
> 1. You can't assume there is bash, therefore you can't use it for tests
> 2. there is `not` tool already
I'll be more specific - you can not use shell at all, regardless of whether it's bash/sh/zsh/...
It should be python-based.


================
Comment at: llvm/test/Reduce/remove-funcs.ll:4
+;
+; RUN: llvm-reduce --test %p/Inputs/remove-funcs.py %s
+; RUN: cat reduced.ll | FileCheck %s
----------------
I think i'm failing to see the purpose of that script.
Why is it needed? FileCheck will fail just as good if it doesn't match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672