[PATCH] D65865: [ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_386

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/plt-i686.s:123
 // 0x3000 + got.plt.reserved(12) = 0x300C
 // 0x3000 + got.plt.reserved(12) + 4 = 0x3010
 // CHECKSHARED:        Relocations [
----------------
grimar wrote:
> These are not valid anymore.
> 
> The others in this file too. Though they seems became broken before this change.
I'll delete

```
// Unfortunately FileCheck can't do math, so we have to check for explicit
// values:

// 16 is the size of PLT[0]
// (0x401010 + 16) - (0x401000 + 1) - 4 = 27
// (0x401010 + 16) - (0x401005 + 1) - 4 = 22
// (0x401020 + 16) - (0x40100a + 1) - 4 = 33
```

Hopefully FileCheck will soon learn how to do math. (There is a patch series but it hasn't fully landed yet.)

jmp instructions are annotated with PLT entries so the math is no longer necessary.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65865/new/

https://reviews.llvm.org/D65865