[PATCH] D65865: [ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_386

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

There are many expressions in the comments which are broken now (i.e. they were broken before this change already),
but also some of expressions were broken by this patch. I marked them in the comments.



================
Comment at: test/ELF/i386-tls-opt-iele-nopic.s:38
 // 4202592 = (.got)[0] = 0x402060
 // 4202596 = (.got)[1] = 0x402064
+// DISASM-NEXT: 4011b0:       movl $4294967288, %ecx
----------------
The last 2 need an update.


================
Comment at: test/ELF/i386-tls-vaddr-align.s:1
+# REQUIRES: ppc
+
----------------
ppc?


================
Comment at: test/ELF/plt-i686.s:123
 // 0x3000 + got.plt.reserved(12) = 0x300C
 // 0x3000 + got.plt.reserved(12) + 4 = 0x3010
 // CHECKSHARED:        Relocations [
----------------
These are not valid anymore.

The others in this file too. Though they seems became broken before this change.


================
Comment at: test/ELF/relocation-copy-i686.s:55
 
-// 4206592 =  0x403000
 // 16 is alignment here
 // CODE: Disassembly of section .text:
----------------
Where? :)


================
Comment at: test/ELF/relocation-i686.s:77
  call bar
 // addr(.plt) + 16 - (0x401019 + 5) = 50
 // CHECK:      Disassembly of section .dynamic_reloc:
----------------
This one is broken now.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65865/new/

https://reviews.llvm.org/D65865