[PATCH] D65813: Partially revert D61491 "AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0"

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 03:23:46 PDT 2019


foad added a comment.

In D65813#1618503 <https://reviews.llvm.org/D65813#1618503>, @nhaehnle wrote:

> Could you please change `shouldEmitConstantsToTextSection` to check for `== AMDPAL` instead? This really doesn't make sense for Mesa... and then add a test that explicit sets amdpal in the triple?


Done. `global-constant.ll` seems to test the HAS/non-HSA (now PAL/non-PAL) difference quite well. I don't know what to make of the other test changes -- I just did what I needed to to make them pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65813/new/

https://reviews.llvm.org/D65813





More information about the llvm-commits mailing list