[PATCH] D65733: [Attributor] Provide easier checkForallReturnedValues functionality

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 09:16:40 PDT 2019


sstefan1 added a comment.

This looks good. Just one comment inlined:



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1001
 
-  if (!AARetVal->checkForallReturnedValues(Pred))
+  if (!AARetVal->checkForAllReturnedValuesAndReturnInsts(Pred))
     return indicatePessimisticFixpoint();
----------------
Shouldn't AANonNullReturned also use A.checkForAllReturnedValuesAndReturnInsts(Pred))?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65733/new/

https://reviews.llvm.org/D65733





More information about the llvm-commits mailing list