[PATCH] D65775: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp:77
+  int rerrno = 0;
+  if (internal_iserror(r, &rerrno) && rerrno == EINVAL)
+    return false;
----------------
devnexen wrote:
> vitalybuka wrote:
> > I guess this should be:
> > ```
> > if (internal_iserror(r, &rerrno) && rerrno == EINVAL)
> >   return true;
> > ```
> > 
> > we get EINVAL for "never"?
> Why true ?
> Ah correct maybe it is more likely EAGAIN.
Have you tried to switch to never and check the error?
In this case I think we want to ignore error and let tsan work.

However maybe it's better to make it
void SetShadowRegionHugePageMode()
and just ignore madvise return value.

And remove error on tsan side




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65775/new/

https://reviews.llvm.org/D65775