[PATCH] D65775: [Sanitizer] Linux explicitally migrate shadow mapping to Transparent Huge Page

[David CARLIER via Phabricator via llvm-commits]

devnexen marked an inline comment as done.
devnexen added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp:77
+  int rerrno = 0;
+  if (internal_iserror(r, &rerrno) && rerrno == EINVAL)
+    return false;
----------------
vitalybuka wrote:
> I guess this should be:
> ```
> if (internal_iserror(r, &rerrno) && rerrno == EINVAL)
>   return true;
> ```
> 
> we get EINVAL for "never"?
Why true ?
Ah correct maybe it is more likely EAGAIN.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65775/new/

https://reviews.llvm.org/D65775