[PATCH] D64424: [AIX] Implement LR prolog/epilog save/restore

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 10:28:42 PDT 2019


sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:62
 
 static unsigned computeFramePointerSaveOffset(const PPCSubtarget &STI) {
   // For the Darwin ABI:
----------------
hubert.reinterpretcast wrote:
> This patch does not add testing for this.
Chris and I had briefly discussed this offline and I asked that we add asserts (or errors) if we need a frame-pointer or base-pointer on AIX. We can then add the testing and remove the assert/errors in a subsequent patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64424/new/

https://reviews.llvm.org/D64424





More information about the llvm-commits mailing list