[PATCH] D64424: [AIX] Implement LR prolog/epilog save/restore

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:62
 
 static unsigned computeFramePointerSaveOffset(const PPCSubtarget &STI) {
   // For the Darwin ABI:
----------------
This patch does not add testing for this.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:83
 
 static unsigned computeBasePointerSaveOffset(const PPCSubtarget &STI) {
   if (STI.isDarwinABI())
----------------
This patch does not add testing for this.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:87
 
-  // SVR4 ABI: First slot in the general register save area.
+  // SVR4/AIX ABI: First slot in the general register save area.
   return STI.isPPC64()
----------------
This looks like a copy/paste error (copied from line 71).


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:90
              ? -16U
              : STI.getTargetMachine().isPositionIndependent() ? -12U : -8U;
 }
----------------
This logic does not seem to be common for 32-bit SVR4 and 32-bit AIX. See `PPCFrameLowering::determineCalleeSaves`:
```
  // Reserve stack space for the PIC Base register (R30).
  // Only used in SVR4 32-bit.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64424/new/

https://reviews.llvm.org/D64424