[PATCH] D65778: [FileCheck] Add missing includes in header
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 6 02:40:39 PDT 2019
thopre updated this revision to Diff 213553.
thopre added a comment.
- Include FileCheck.h first
- Remove includes in FileCheck.cpp of headers already included in FileCheck.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65778/new/
https://reviews.llvm.org/D65778
Files:
llvm/include/llvm/Support/FileCheck.h
llvm/lib/Support/FileCheck.cpp
Index: llvm/lib/Support/FileCheck.cpp
===================================================================
--- llvm/lib/Support/FileCheck.cpp
+++ llvm/lib/Support/FileCheck.cpp
@@ -15,10 +15,10 @@
#include "llvm/Support/FileCheck.h"
#include "llvm/ADT/StringSet.h"
+#include "llvm/ADT/Twine.h"
#include "llvm/Support/FormatVariadic.h"
#include <cstdint>
#include <list>
-#include <map>
#include <tuple>
#include <utility>
Index: llvm/include/llvm/Support/FileCheck.h
===================================================================
--- llvm/include/llvm/Support/FileCheck.h
+++ llvm/include/llvm/Support/FileCheck.h
@@ -13,12 +13,16 @@
#ifndef LLVM_SUPPORT_FILECHECK_H
#define LLVM_SUPPORT_FILECHECK_H
+#include "llvm/ADT/Optional.h"
#include "llvm/ADT/StringMap.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/Regex.h"
#include "llvm/Support/SourceMgr.h"
-#include <vector>
#include <map>
+#include <string>
+#include <vector>
namespace llvm {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65778.213553.patch
Type: text/x-patch
Size: 1055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190806/9fd6fda4/attachment.bin>
More information about the llvm-commits
mailing list