[PATCH] D65778: [FileCheck] Add missing includes in header

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:22
+#include "llvm/Support/Error.h"
+#include "llvm/Support/FileCheck.h"
 #include "llvm/Support/FormatVariadic.h"
----------------
Have you read the [[ https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible | relevant part of the coding standards ]]? llvm/Support/FileCheck.h should be first as the file's own header. Additionally, clang-format sorts things appropriately, and the coding standards say you don't need to include headers if they're included by a referenced header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65778/new/

https://reviews.llvm.org/D65778