[PATCH] D65746: [ARM] Generate VHADDs/VHSUBs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 5 07:51:05 PDT 2019


dmgreen added a comment.

Hello. Remember to upload with full context (-U999999)! It makes reviews easier.



================
Comment at: lib/Target/ARM/ARMInstrMVE.td:1567
+                     (v16i8 (add (v16i8 MQPR:$v1), (v16i8 MQPR:$v2))), 1)),
+            (v16i8 (!cast<Instruction>("MVE_VHADDs8")
+                     (v16i8 MQPR:$v1), (v16i8 MQPR:$v2)))>;
----------------
I don't think you will need the casts, if you just use the instruction names directly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65746/new/

https://reviews.llvm.org/D65746





More information about the llvm-commits mailing list