[PATCH] D65680: [yaml2obj][tests] Fix overly restrictive od output check

Sat Aug 3 01:37:32 PDT 2019

grimar added a comment.

> rL364517 <https://reviews.llvm.org/rL364517> introduced further instances of od output checking of the kind previously corrected by rL363829 <https://reviews.llvm.org/rL363829>.

I leaved a comment for rL363829 <https://reviews.llvm.org/rL363829>, it seems broke at least one of the tests.

================
Comment at: test/tools/yaml2obj/elf-header-sh-fields.yaml:50
+# NEWSIZE: {{^[^[:blank:]]+}} 01
+# OLDSIZE: {{^[^[:blank:]]+}} 40

----------------
Previously it tested that `e_shentsize` in ELF header at offset 0x72 contained value 64 (0x40) and with this YAML we changed it to 0x01.
But your version just test that somewhere in the file there are bytes 0x01 and 0x40 I think. Am I missing something?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65680/new/

https://reviews.llvm.org/D65680