[PATCH] D65680: [yaml2obj][tests] Fix overly restrictive od output check

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 2 16:51:29 PDT 2019


hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: grimar, xingxue, daltenty, jasonliu.
Herald added a project: LLVM.

rL364517 <https://reviews.llvm.org/rL364517> introduced further instances of `od` output checking of the kind previously corrected by rL363829 <https://reviews.llvm.org/rL363829>. A similar fix is applied in this patch. The check remains sufficiently sensitive to test for the intended value of the specific byte.


Repository:
  rL LLVM

https://reviews.llvm.org/D65680

Files:
  test/tools/yaml2obj/elf-header-sh-fields.yaml


Index: test/tools/yaml2obj/elf-header-sh-fields.yaml
===================================================================
--- test/tools/yaml2obj/elf-header-sh-fields.yaml
+++ test/tools/yaml2obj/elf-header-sh-fields.yaml
@@ -46,8 +46,8 @@
 # RUN: yaml2obj --docnum=3 %s -o %t3
 # RUN: od -t x1 -v -j 0x3a -N 1 %t3 | FileCheck %s --check-prefix=NEWSIZE
 # RUN: od -t x1 -v -j 0x3a -N 1 %t2 | FileCheck %s --check-prefix=OLDSIZE
-# NEWSIZE: 0000072 01
-# OLDSIZE: 0000072 40
+# NEWSIZE: {{^[^[:blank:]]+}} 01
+# OLDSIZE: {{^[^[:blank:]]+}} 40
 
 --- !ELF
 FileHeader:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65680.213145.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190802/41fdf953/attachment.bin>


More information about the llvm-commits mailing list