[PATCH] D65683: MVT: Add v3i16/v3f16 vectors

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: include/llvm/CodeGen/ValueTypes.td:126
+def v2f16    : ValueType<32 , 93>;    //    2 x f16 vector value
+def v3f16    : ValueType<32 , 94>;    //    3 x f16 vector value
+def v4f16    : ValueType<64 , 95>;    //    4 x f16 vector value
----------------
Size should be 48?


================
Comment at: include/llvm/Support/MachineValueType.h:635
       case nxv4f64: return 4;
       case v3i32:
+      case v3f32:
----------------
Aren't these generally sorted by integer vs fp then element size?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65683/new/

https://reviews.llvm.org/D65683