[PATCH] D65608: [llvm-readelf] Fix core note descriptions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 21:14:59 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1367
+  NT_AUXV = 6,
+  NT_PRXFPREG = 0x46e62b7f,
+  NT_PPC_VMX = 0x100,
----------------
Sort the enum members?

(binutils-gdb and Linux uapi have different orders, but I don't see any problem if we just sort them and move NT_PRXFPREG below to be beside NT_FILE and NT_SIGINFO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65608/new/

https://reviews.llvm.org/D65608





More information about the llvm-commits mailing list