[PATCH] D65608: [llvm-readelf] Fix core note descriptions

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 14:39:57 PDT 2019


rupprecht created this revision.
rupprecht added a reviewer: MaskRay.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Core files have different descriptions for note values. llvm-readelf currently prints the generic note type, which is wrong when using it to read a core file.

To verify the constants/strings, see:
Values: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=include/elf/common.h;h=75c4fb7e9d7c0f780d635ac305f579546b7b071b;hb=HEAD#l571
Strings: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=binutils/readelf.c;h=c31a5c1266b7bb62a485895b01b49e1f832ade35;hb=HEAD#l16881

Note: this does not handle printing the note data for NT_FILE, it just fixes the descriptions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65608

Files:
  llvm/include/llvm/BinaryFormat/ELF.h
  llvm/test/tools/llvm-readobj/note-core.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65608.212909.patch
Type: text/x-patch
Size: 8236 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190801/1cced312/attachment.bin>


More information about the llvm-commits mailing list