[PATCH] D65474: [SCEV] Return zero from computeConstantDifference(X, X)

[Nikolai Bozhenov via Phabricator via llvm-commits]

n.bozhenov updated this revision to Diff 212944.
n.bozhenov added a comment.

I am afraid implementing a test through friendship would be pretty cumbersome.
ScalarEvolutionsTest performs checks inside lambdas, while the friendship does
not propagate inside lambdas.

A more straightforward approach would be to make computeConstantDifference
public. Please, check the updated patch with a unit test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65474/new/

https://reviews.llvm.org/D65474

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/unittests/Analysis/ScalarEvolutionTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65474.212944.patch
Type: text/x-patch
Size: 5020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190802/4cfbe6e8/attachment.bin>