[PATCH] D65474: [SCEV] Return zero from computeConstantDifference(X, X)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 01:36:59 PDT 2019


fhahn added a comment.

IMO it would make sense to add isolated unit tests to llvm/unittests/Analysis/ScalarEvolutionTest.cpp for such behavior. It should be easy to test there. I *think* there should be no harm in making ScalarEvolutionTest a friend of ScalarEvolution to test private members.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65474/new/

https://reviews.llvm.org/D65474





More information about the llvm-commits mailing list