[PATCH] D64185: [NewPM] Port FinalizeISel to the new pass manager.

[Charles Zhang via Phabricator via llvm-commits]

czhang added a comment.

In D64185#1607313 <https://reviews.llvm.org/D64185#1607313>, @arsenm wrote:

> Just because the IR passes made a mess of this doesn't mean the same mistake should be repeated for CodeGen passes. I think the clutter of the pass headers should be sorted away to reduce the mental burden of figuring out which headers should be included by machine passes


I definitely hear what you are saying, but for the sake of consistency I believe it would be less confusing if we followed the IR pass convention for now. Then we could discuss potentially cleaning up both the IR pass and CodeGen pass headers at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64185/new/

https://reviews.llvm.org/D64185