[PATCH] D64185: [NewPM] Port FinalizeISel to the new pass manager.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Just because the IR passes made a mess of this doesn't mean the same mistake should be repeated for CodeGen passes. I think the clutter of the pass headers should be sorted away to reduce the mental burden of figuring out which headers should be included by machine passes



================
Comment at: llvm/lib/CodeGen/CodeGen.cpp:36
   initializeFEntryInserterPass(Registry);
-  initializeFinalizeISelPass(Registry);
+  initializeFinalizeISelLegacyPassPass(Registry);
   initializeFinalizeMachineBundlesPass(Registry);
----------------
No PassPass


================
Comment at: llvm/lib/CodeGen/FinalizeISel.cpp:46
+char &llvm::FinalizeISelID = FinalizeISelLegacyPass::ID;
+INITIALIZE_PASS(FinalizeISelLegacyPass, DEBUG_TYPE,
                 "Finalize ISel and expand pseudo-instructions", false, false)
----------------
Remove pass to avoid PassPass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64185/new/

https://reviews.llvm.org/D64185