[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 11:16:44 PDT 2019


jdenny added a comment.

In D65121#1610682 <https://reviews.llvm.org/D65121#1610682>, @probinson wrote:

> Wouldn't it work just as well to say
>
>   RUN: %TestFileCheckOut \
>   RUN: not FileCheck blahblah | FileCheck yadayada
>
>
> which keeps the `not` adjacent to the `FileCheck` (and incidentally sidesteps the "not runs env as an external command" problem).


Yes, I like that better too.  Thanks!



================
Comment at: llvm/test/FileCheck/check-count.txt:7
 
-; RUN: not FileCheck %s --input-file %s --check-prefix=CHECK-ERR1 2>&1 | FileCheck %s --check-prefix=ERRCOUNT1
+; RUN: not %TestFileCheckOut \
+; RUN: FileCheck %s --input-file %s --check-prefix=CHECK-ERR1 2>&1 \
----------------
Instead of that, just add a preceding line with

```
; RUN: %TestFileCheckOut \
```

Likewise everywhere else.

See <https://reviews.llvm.org/D65121#1610682>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121





More information about the llvm-commits mailing list