[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Getting back to this after a long month on first-responder-to-bugs duty.  I know you're trying to get the lit/env issue sorted out, but I had a half hour available to look at this.

It makes me very sad to see
`RUN: not FileCheck blahblah | FileCheck yadayada`
become

  RUN: not %TestFileCheckOut \
  RUN: FileCheck blahblah | FileCheck yadayada

Wouldn't it work just as well to say

  RUN: %TestFileCheckOut \
  RUN: not FileCheck blahblah | FileCheck yadayada

which keeps the `not` adjacent to the `FileCheck` (and incidentally sidesteps the "not runs env as an external command" problem).



================
Comment at: llvm/test/FileCheck/lit.local.cfg:3
+# textual output affects test results.  It's usually easy to tell: just look
+# for redirection or piping of the FileCheck call's stdout or stderr.
+#
----------------
Okay, that seems pretty straightforward and easy to understand.


================
Comment at: llvm/test/FileCheck/lit.local.cfg:51
+config.substitutions.append(('%TestFileCheckOut',
+    'env -u FILECHECK_OPTS -u FILECHECK_DUMP_INPUT_ON_FAILURE'))
----------------
This will clearly have to be changed to solve the problems found after D65156.  But it can wait until that is sorted out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121