[PATCH] D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 1 01:51:13 PDT 2019


hans added a comment.

In D64483#1606208 <https://reviews.llvm.org/D64483#1606208>, @ro wrote:

> In D64483#1605989 <https://reviews.llvm.org/D64483#1605989>, @ro wrote:
>
> > In D64483#1605895 <https://reviews.llvm.org/D64483#1605895>, @hans wrote:
> >
> > > > Thanks.  Would this and its companion D64482 <https://reviews.llvm.org/D64482> be appropriate for the 9.x branch, too?  If so, what's the procedure to get it there?
> > >
> > > Probably. They need to land on trunk first, then let me know and I'll merge them.
> >
> >
> > Both patches are in now.  However, there's a buildbot failure <http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/33923>
> >  that claims to be related, though I cannot see yet how this can possibly happen.
>
>
> The next builds of both affected buildbots [[http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast] and http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux
>  are fine again, so this seem to have been transient failures unrelated to my patches.
>
> From the POV, they seem good to go for a backport.


Yes, I've merged both in r367526 and r367527, respectively.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64483/new/

https://reviews.llvm.org/D64483





More information about the llvm-commits mailing list