[PATCH] D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D64483#1591428 <https://reviews.llvm.org/D64483#1591428>, @ro wrote:

> In D64483#1590120 <https://reviews.llvm.org/D64483#1590120>, @rnk wrote:
>
> > I would place this macro setting with the other code that sets this macro, in cmake/modules/HandleLLVMOptions.cmake.
>
>
> This doesn't work unfortunately: I still get the same link failure for `Sanitizer-i386-Test` with gcc 9.  For the original patch I'd followed how things are done
>  for AIX (`_XOPEN_SOURCE=700`, `_LARGE_FILE_API`) which is similar.


I don't understand how that could be, but I can't investigate since I don't have solaris set up. HandleLLVMOptions.cmake is included from llvm/CMakeLists.txt right above the code you are modifying, and it calls add_definitions as well, so it should work exactly the same.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64483/new/

https://reviews.llvm.org/D64483