[PATCH] D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index.

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 31 10:53:02 PDT 2019


tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:495
         return true;
+    } else if (Name == "call_indirect") {
+      // This has a special TYPEINDEX operand which in text we
----------------
tlively wrote:
> We should add `return_call_indirect` support as well, but probably in a separate CL.
Actually, there should be no different work to do for `return_call_indirect` because the text format should contain the correct return type. So it would be good to add that case to this condition now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64758/new/

https://reviews.llvm.org/D64758





More information about the llvm-commits mailing list