[PATCH] D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index.

Tue Jul 30 23:03:32 PDT 2019

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

This looks great! The code is straightforward and I like the extra information in the text format. We will have to do a little more work to support `return_call_indirect`, but it looks like doing so should be fairly straightforward on top of this base.

================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:495
         return true;
+    } else if (Name == "call_indirect") {
+      // This has a special TYPEINDEX operand which in text we
----------------
We should add `return_call_indirect` support as well, but probably in a separate CL.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64758/new/

https://reviews.llvm.org/D64758