[PATCH] D63547: [AIX]Global Address Lowering

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L marked 4 inline comments as done.
Xiangling_L added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5091
+    // Transforms the ISD::TOC_ENTRY node to a PPCISD::LWZtoc.
+    auto replaceWithLWZtoc = [this, dl](SDNode *TocEntry) {
+      SDValue GA = TocEntry->getOperand(0);
----------------
hubert.reinterpretcast wrote:
> Put this into a `!isPPC64` block.
I think the usage of `replaceWithLWZtoc` itself is guarded by `!isPPC64`, do we still need add `!isPPC64` for this block? Or we can add a comment specifying it's 32bit only?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63547/new/

https://reviews.llvm.org/D63547